Review Request 118852: [kconfig] Fix build on Visual C++ 2010

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118852/#review61121
-----------------------------------------------------------

Ship it!


Then I don't understand why all the other writeEntry calls in this file are fine....

But OK whatever, we're not going to debug the internals of MSVC.

- David Faure


On June 21, 2014, 12:20 a.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118852/
> -----------------------------------------------------------
> 
> (Updated June 21, 2014, 12:20 a.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Visual C++ 2010 throws an internal compiler error trying to compile kconfigtest, since 5f4dc2973f. I couldn't figure out a non-intrusive code tweak that would work around the ICE, so I had to skip compiling this particular initialization code on this particular compiler version, and skip running the test that relies on it (testEnums).
> 
> The dummy=42 entry is so that the config group isn't empty, which makes testGroupCopyTo and testReparent still run and pass.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp a8482b7 
> 
> Diff: https://git.reviewboard.kde.org/r/118852/diff/
> 
> 
> Testing
> -------
> 
> Compiles on MSVC2010, kconfigtest passes (with testEnums skipped).
> 
> I haven't tried compiling on other compilers.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140628/5a0bd5f1/attachment-0001.html>