Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

David Faure faure at kde.org
Fri Jun 27 22:31:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118985/
-----------------------------------------------------------

Review request for KDE Frameworks and Matthew Dawson.


Repository: kconfig


Description
-------

KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

As a side effect, this removes the need for the atomic ints, since
that code now only runs in the main thread.


Diffs
-----

  src/core/ksharedconfig.cpp b7d155d5893502921d35d7dd971188b6a93a0620 

Diff: https://git.reviewboard.kde.org/r/118985/diff/


Testing
-------

no regression in "make test" in kconfig; still debugging races in helgrind threadtest (in kio).


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140627/6132f8b1/attachment.html>


More information about the Kde-frameworks-devel mailing list