Review Request 118962: Add api for setting download widget and dialog title. Helps with bug 336737
Marco Martin
notmart at gmail.com
Fri Jun 27 10:21:48 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118962/#review61080
-----------------------------------------------------------
+1 from me!
src/downloaddialog.h
<https://git.reviewboard.kde.org/r/118962/#comment42536>
maybe a getter too for simmretry?
- Marco Martin
On June 26, 2014, 7:03 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118962/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 7:03 p.m.)
>
>
> Review request for KDE Frameworks, Marco Martin and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> Add api for setting download widget and dialog title. Helps with bug 336737
>
>
> Diffs
> -----
>
> src/downloaddialog.h 7d8f2b40ee46baf18af401631816e0623d797623
> src/downloaddialog.cpp d29768bda622fd9324e34c66503a78e0729dfc8e
> src/downloadwidget.h e4643aad853d76927be5d67714c5eff1c8c4e8d1
> src/downloadwidget.cpp 186939bfbfeebfaacc9c25ebbe5aaaf5cb277c20
>
> Diff: https://git.reviewboard.kde.org/r/118962/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140627/d69aadf5/attachment.html>
More information about the Kde-frameworks-devel
mailing list