Review Request 118946: Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118946/#review60994
-----------------------------------------------------------


this is however not ABI relevant, so depending on schedules one *could* wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop symbol: removing it from the enum is oc. not API stable, thus not possible) and be introduced even with KWin 5.0.3 or whatever the final name scheme will be ;-)

- Thomas Lübking


On June 26, 2014, 7:22 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118946/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 7:22 a.m.)
> 
> 
> Review request for KDE Frameworks and kwin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2
> 
> Although non-standard it needs to be added to the NET::PRoperties2
> in order to have KWin announce it in the supported section.
> 
> As soon as this gets standardized WM2ShowWindowMenu can be changed
> to point to both the proprietary GTK hint and the standardized hint.
> 
> 
> Diffs
> -----
> 
>   autotests/netrootinfotestwm.cpp f8c28be51e5a5b19d436c54eede0e8659a65c84e 
>   src/netwm.cpp 1daad1e5fc87fa85da6348a059d0ae0acec26eaf 
>   src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 
> 
> Diff: https://git.reviewboard.kde.org/r/118946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140626/fc0bb1e0/attachment.html>