Review Request 118879: Revert to old shell script code for parsing rgb.txt
Aurélien Gâteau
agateau at kde.org
Mon Jun 23 08:28:22 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118879/#review60754
-----------------------------------------------------------
Out of curiosity: why is it necessary to skip colors with spaces?
- Aurélien Gâteau
On June 22, 2014, 2:30 p.m., Alexander Potashev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118879/
> -----------------------------------------------------------
>
> (Updated June 22, 2014, 2:30 p.m.)
>
>
> Review request for KDE Frameworks and Aurélien Gâteau.
>
>
> Repository: kdelibs4support
>
>
> Description
> -------
>
> The code using AWK did not properly throw away entries containing
> spaces.
>
> The code inserted in this commit was used successfully in KDE SC 4, see
> kdelibs/kdeui/colors/Messages.sh
>
>
> Diffs
> -----
>
> src/Messages.sh 9b918fa
>
> Diff: https://git.reviewboard.kde.org/r/118879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Potashev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140623/1610e2e7/attachment.html>
More information about the Kde-frameworks-devel
mailing list