Review Request 118853: Log name + size of not found icons in debug output

[Luigi Toscano]

> On June 21, 2014, 11:36 a.m., Christoph Feck wrote:
> > What is the status of categorized debugging/logging support in Qt, and how do we utilize that in our frameworks?
> > 
> > If we are still simply using uncategorized qDebug(), please commit it.

We can use qCDebug; the only problem is that right now (for what I know) categories can't be enabled/disabled dynamically, but statically from the code. See:
http://community.kde.org/Frameworks/Porting_To_qCDebug


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118853/#review60646
-----------------------------------------------------------


On June 21, 2014, 4:53 a.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118853/
> -----------------------------------------------------------
> 
> (Updated June 21, 2014, 4:53 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Currently I get to see this debug log message quite often:
> 
> Warning: could not find "unknown" icon for size 48
> 
> This makes it hard to find out which icon was originally requested.
> This patch adds a debug log message including the name + size of the not found icon before attempting to load the "unknown" icon.
> 
> 
> Diffs
> -----
> 
>   src/kiconloader.cpp 6e22f3e864db190f409550fcac964154c895ca6b 
> 
> Diff: https://git.reviewboard.kde.org/r/118853/diff/
> 
> 
> Testing
> -------
> 
> Debug log messages look now like this:
> 
> Icon "konsole" for size 48 not found
> Warning: could not find "unknown" icon for size 48
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140621/fc4f25a3/attachment.html>