Review Request 118846: Turn KLauncher into a QGuiApplication

[Martin Gräßlin]

> On June 20, 2014, 7:05 p.m., David Faure wrote:
> > Strange, why wasn't this necessary in kdelibs4?

see the linked bug report. It's basically a regression due to introducing platform detection (X11 vs. Wayland) in both klauncher and KWindowSystem. My first idea to fix it was to check for DISPLAY variable set instead of checking the platformName, but going deeper showed that it would fail in all the KWindowSystem checks, too.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118846/#review60615
-----------------------------------------------------------


On June 20, 2014, 1:51 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118846/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 1:51 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Harald Sitter.
> 
> 
> Bugs: 336488
>     https://bugs.kde.org/show_bug.cgi?id=336488
> 
> 
> Repository: kinit
> 
> 
> Description
> -------
> 
> Turn KLauncher into a QGuiApplication
> 
> klauncher uses the X11 windowing system which means it should be a
> QGuiApplication. This is important as otherwise all the runtime checks
> for whether X11 is used will fail. This is not only inside KLauncher
> itself, but also in KWindowSystem.
> 
> BUG: 336488
> 
> 
> Diffs
> -----
> 
>   src/klauncher/klauncher_main.cpp 02e64b704308b6e815019e719eb7a37f3683127a 
> 
> Diff: https://git.reviewboard.kde.org/r/118846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140620/77991858/attachment.html>