Review Request 118846: Turn KLauncher into a QGuiApplication

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118846/#review60591
-----------------------------------------------------------

Ship it!


looks good to me

- Harald Sitter


On June 20, 2014, 11:51 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118846/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 11:51 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Harald Sitter.
> 
> 
> Bugs: 336488
>     https://bugs.kde.org/show_bug.cgi?id=336488
> 
> 
> Repository: kinit
> 
> 
> Description
> -------
> 
> Turn KLauncher into a QGuiApplication
> 
> klauncher uses the X11 windowing system which means it should be a
> QGuiApplication. This is important as otherwise all the runtime checks
> for whether X11 is used will fail. This is not only inside KLauncher
> itself, but also in KWindowSystem.
> 
> BUG: 336488
> 
> 
> Diffs
> -----
> 
>   src/klauncher/klauncher_main.cpp 02e64b704308b6e815019e719eb7a37f3683127a 
> 
> Diff: https://git.reviewboard.kde.org/r/118846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140620/7a082abf/attachment.html>