Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114283/
-----------------------------------------------------------

(Updated June 19, 2014, 6 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Rebased on master.
Split from ScrollArea like we did for combo box
Removed final hardcoded values

Tested Kickoff with both Breeze and Oxygen as oxygen includes up/down arrows whereas Breeze does not.
Both appeared correctly.


Repository: plasma-framework


Description
-------

Use QtQuickControls ScrollView internally

Flickable has a very odd API in which contentHeight can't be trusted. we need to update our ScrollBars/ScrollArea to make use of the new
originX and originY in order to fix a lot of bugs that we currently see with scrollbars.

Instead of doing that, by porting to use QtQuick Controls we get all
these bug fixes as well as _significantly_ reducing our code.

Having a separate logic vs UI, makes things (IMHO) easier to read.

I don't expect to merge this as-is; I haven't included the plasma
feature that creates a SectionScroller if the content is a listview, but
that should be viable. As far as I know all other features (keyboard
controls / hiding buttons on touch screens) are still kept.

Files removed are as indication as to long term changes from making this
change, in order to do that we need to port all users from ScrollBars ->
ScrollArea. (which is worth doing anyway IMHO)


Diffs (updated)
-----

  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 860c0e7 
  src/declarativeimports/plasmaextracomponents/qml/styles/ScrollViewStyle.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114283/diff/


Testing
-------

Widget Explorer in plasma-shell looks exactly as before.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140619/7bc89bf7/attachment-0001.html>