Review Request 118838: Don't require mandatory subText in tooltip

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/#review60511
-----------------------------------------------------------


yeah, the code was wrong, just a small issue on the patch


src/declarativeimports/core/tooltip.cpp
<https://git.reviewboard.kde.org/r/118838/#comment42259>

    I think it should rather be
    if (m_mainItem || !mainText().isEmpty() || !subText().isEmpty())
    
    ie the tooltip must have at least one between:
    * a custom mainitem
    * a title
    * a subtitle


- Marco Martin


On June 19, 2014, 12:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118838/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 12:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Don't require mandatory subText in tooltip
> 
> I wasted ages yesterday trying to work out why my tooltip wasn't showing in my code; turns out it's because I didn't have a subtext.
> Besides the current implementation is broken; if the tooltip is already showing somewhere else then this check is skipped entirely.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.cpp 11aaaff 
> 
> Diff: https://git.reviewboard.kde.org/r/118838/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140619/b08e9bc3/attachment.html>