Review Request 118538: Add a property containing the real edge a dialog is shown on

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118538/
-----------------------------------------------------------

(Updated June 18, 2014, 9:09 a.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

Add a property containing the real edge a dialog is shown on.

If a dialog is meant to be shown on the left of an item, if there is not
enough space it will be shown on the right.

We need to keep track of where we're actually shown in order to show the
correct borders and perform the animation in the correct direction.

It is exposed as a property in case the dialog itself needs to know
which side of the parent item it is, for example if needs to show an
arrow to the parent.

--

Fixed some serious copy + paste fails in the hitting the bottom edge of
the screen check.


Diffs
-----

  src/plasmaquick/dialog.cpp 2f8227c 
  src/plasmaquick/dialog.h 4009222 

Diff: https://git.reviewboard.kde.org/r/118538/diff/


Testing
-------

Ran dialog_positioning.qml in all 8 combinations of edges + preferred locations.
(i.e placed near left edge, showed item with location set to both left and right)


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140618/f0e29080/attachment-0001.html>