Review Request 118740: Use standard message box icon size in password dialogs

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118740/#review60283
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On June 14, 2014, 11:11 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118740/
> -----------------------------------------------------------
> 
> (Updated June 14, 2014, 11:11 a.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Bugs: 336141
>     https://bugs.kde.org/show_bug.cgi?id=336141
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> In KDE 4, we used hard coded sizes of 128 or 96 pixels to make sure the user notices the importance of the dialogs.
> 
> This patch changes it to use QStyle standard sizes for message box icons. If we want to continue using larger icon sizes for our platform, we can change them in our QStyle.
> 
> 
> Diffs
> -----
> 
>   src/knewpassworddialog.cpp 7fe3df2 
>   src/kpassworddialog.cpp 88c821e 
> 
> Diff: https://git.reviewboard.kde.org/r/118740/diff/
> 
> 
> Testing
> -------
> 
> None, I still do not have a KF5 setup...
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140617/d0f2d9b4/attachment.html>