Review Request 118667: KCrash: call setgroups(0, 0) before calling setgid()

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118667/
-----------------------------------------------------------

(Updated June 16, 2014, 12:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcrash


Description
-------

While packaging kcrash, we got a warning from rpmlint that KCrash calls setgid() without calling setgroups() first. From rpmlint:

   This executable is calling setuid and setgid without setgroups or initgroups.
   There is a high probability this mean it didn't relinquish all groups, and
   this would be a potential security issue to be fixed. Seek POS36-C on the web
   for details about the problem.

The reasoning is that when you drop privileges from root to regular user, there might be some extra groups left that, if not cleared, might grant the process privileges to do superuser things.

The code does not check for return value, as the call will fail if we are not a superuser.

This oneliner makes rpmlint happy and maybe prevents a security issue.


Diffs
-----

  src/kcrash.cpp f05385b 

Diff: https://git.reviewboard.kde.org/r/118667/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140616/108a16cc/attachment.html>