Review Request 118690: Introduce a KLocalizedTranslator

[Martin Gräßlin]

> On June 13, 2014, 1:06 a.m., Albert Astals Cid wrote:
> > What's the use case? Didn't we have a different way for translating ui files?

> What's the use case?

well as explained in the comment for translating dynamically loaded UI files. Where is that used? In KWin for the configuration of scripts and scripted effects (example: translucency effect).

> Didn't we have a different way for translating ui files?

I'm not aware of one and AFAIU ki18n it would need to have compiled sources which is not possible with the given use case.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118690/#review59925
-----------------------------------------------------------


On June 12, 2014, 10:55 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118690/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 10:55 a.m.)
> 
> 
> Review request for KDE Frameworks, Aurélien Gâteau and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Introduce a KLocalizedTranslator
> 
> The KLocalizedTranslator is a QTranslator subclass which can delegate
> to ki18n for translations. This class allows to translate text which
> can only use Qt's translation system with ki18n.
> 
> 
> Diffs
> -----
> 
>   autotests/klocalizedstringtest.h 52b6248270e7d117855cb96c5d3d8582d89a99b0 
>   autotests/klocalizedstringtest.cpp e4e97ce92224f8886705c39091a5f07ea3a209d1 
>   src/CMakeLists.txt 09490e54ecd2126873482b187b17642c57ca7d28 
>   src/klocalizedtranslator.h PRE-CREATION 
>   src/klocalizedtranslator.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118690/diff/
> 
> 
> Testing
> -------
> 
> see added unit test and class already used in (and implemented for) KWin.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140613/fb610176/attachment.html>