Review Request 118564: Fix locale-aware reading in KDesktopFile

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118564/#review59828
-----------------------------------------------------------

Ship it!


LGTM.  The licence header has some extra whitespace.  Please remove then commit. 


autotests/helper.h
<https://git.reviewboard.kde.org/r/118564/#comment41673>

    Nitpick: whitespace.



autotests/helper.h
<https://git.reviewboard.kde.org/r/118564/#comment41674>

    Whitespace



autotests/helper.h
<https://git.reviewboard.kde.org/r/118564/#comment41675>

    Whitespace


- Matthew Dawson


On June 11, 2014, 2:54 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118564/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 2:54 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Fix locale-aware reading in KDesktopFile
> 
> The underlying KConfig used QLocale::name() for getting the locale
> aware part. But this returns "de_DE" while the desktop files store
> "de".
> 
> In addition it constructs a QLocale object instead of using the
> system locale. This has the advantage that the usage of
> QLocale::setDafault() gets honored by KConfig.
> 
> 
> Diffs
> -----
> 
>   autotests/helper.h PRE-CREATION 
>   autotests/kconfigtest.cpp 2b6de0d7d63df6aee69210aa09418628f0b8110a 
>   autotests/kdesktopfiletest.h d57351fd6edcefd6a0efd9126e454546cfc63b55 
>   autotests/kdesktopfiletest.cpp 494a43c0fb5808a261b9beb56cdc4afd8580ab21 
>   src/core/kconfig.cpp ea9746c001e235529a1cdd5865b9e1b5c129b56a 
> 
> Diff: https://git.reviewboard.kde.org/r/118564/diff/
> 
> 
> Testing
> -------
> 
> added unit test failed before. I'm not 100 % sure whether using bcp47Name is correct.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140611/1d23cf30/attachment-0001.html>