Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118630/
-----------------------------------------------------------

(Updated June 10, 2014, 2:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
-------

Consider Super_L and Super_R as modifiers

Without this patch, I can't use the meta key to assign shortcuts, as
Super_L and Super_R are not considered as modifiers, so when I press
meta (Super_L on my system), the shortcut is immediately accepted,
before I get the chance to press another key.

This patch requires the fix in
https://bugreports.qt-project.org/browse/QTBUG-38428
to be applied. With both patches, the QtQuick widgets to assign
shortcuts works for me also with the Meta key.

Suggested by David Edmundson in review request at
https://git.reviewboard.kde.org/r/118581/

CCBUG:335316


Diffs
-----

  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp 7bf67ecb68c97086c0d858ef7c7f774ae0560983 

Diff: https://git.reviewboard.kde.org/r/118630/diff/


Testing
-------

Tested assigning Meta + L to digital clock plasmoid, works with the patch, doesn't work without (displays garbage like in the linked bugreport).


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140610/50e42a49/attachment-0001.html>