Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

David Faure faure at kde.org
Sat Jun 7 13:07:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118499/#review59505
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On June 3, 2014, 4:53 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118499/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 4:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> Put kparts into a kf5/parts subdirectory of the plugins dir
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8a64eace8a579e8a588fcb08e193ce26c463bd68 
>   src/java/CMakeLists.txt 9ff8cdf6ac3b168a83e46db62638119ac011de83 
>   src/java/kjavaappletviewer.desktop 7c3e7fa8bc484659ae7946fcc584c58cad82d47f 
>   src/khtml.desktop f8596232692a6eba1052527e169305771e72cc5a 
>   src/khtmladaptorpart.desktop fc5587e683a07baf03b2913612d558b8e11c163c 
>   src/khtmlimage.desktop 5bdd5b1e0070b439cfbaa7dd4ec8a18a917f54b6 
>   src/kmultipart/CMakeLists.txt 40f5051b6d76615e939d35bedd2ebd37f2bf337f 
>   src/kmultipart/kmultipart.desktop 6bc38afb9b6bca4d9792c0ecdcf6697a1976e1e7 
> 
> Diff: https://git.reviewboard.kde.org/r/118499/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, ran tests. The partviewer in the tests/ directory of KParts successfully loads khtml when you point it at a HTML file. I can't get it to load any of the other parts, though, with or without this patch.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140607/c22c4298/attachment.html>


More information about the Kde-frameworks-devel mailing list