Review Request 118566: KAcceleratorManager: ignore Designer text fields

Commit Hook null at kde.org
Fri Jun 6 08:02:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118566/#review59379
-----------------------------------------------------------


This review has been submitted with commit 7136d783609f4a12ffc167f908b82e59c99148c2 by Aurélien Gâteau to branch master.

- Commit Hook


On June 5, 2014, 1:54 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118566/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 1:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Designer text property editor wraps a QLineEdit and exposes a similar "text" property. Since the editor does not inherit from QLineEdit, it was not ignored and thus trying to set the name of a widget would result in '&' chars being inserted.
> 
> 
> Diffs
> -----
> 
>   src/kacceleratormanager.cpp 6d4c0d4 
> 
> Diff: https://git.reviewboard.kde.org/r/118566/diff/
> 
> 
> Testing
> -------
> 
> Text fields in designer property editor are now editable as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140606/71cc6407/attachment.html>


More information about the Kde-frameworks-devel mailing list