Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

Matthew Dawson matthew at mjdsystems.ca
Thu Jun 5 14:52:32 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118490/
-----------------------------------------------------------

(Updated June 5, 2014, 2:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Repository: kdnssd


Description
-------

Properly mark ServiceBrowser::isRunning as deprecated.

Fix the @deprecated notation to be correct.  Also, make the function a simple
inline function that always returns false.  This should cause minimal breakage
while avoiding overhead from the function.


Diffs
-----

  src/mdnsd-servicetypebrowser.cpp d16dd1fa1c692cd20e21f1a7d5471ac7956469b3 
  src/dummy-servicetypebrowser.cpp 39a4b6b660bb47b68b5721535994487dbe2abbf6 
  src/avahi-servicetypebrowser.cpp b3c14f84367d5093a6cee5ef3f684edc201a3f96 
  src/servicetypebrowser.h 3cd10e36bf089e088e8a48bb0cf73daa4fb859c5 

Diff: https://git.reviewboard.kde.org/r/118490/diff/


Testing
-------

Code still compiles.


Thanks,

Matthew Dawson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140605/15b98aa1/attachment.html>


More information about the Kde-frameworks-devel mailing list