Review Request 118547: Expose Formats as singleton

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118547/
-----------------------------------------------------------

(Updated June 5, 2014, 9 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdeclarative


Description
-------

Expose Formats as singleton

Formats is basically just a collection of invokable static methods.
This saves creating a few objects and makes for a a nicer API.

Without it you have to have a bit of code like:

-    KCoreAddons.Formats {
-        id: formats
-    }
then do text:formats.formatData(...) in your labels

this becomes now

KCoreAddons.Format.formatData(...) 


Diffs
-----

  src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 65dd75f 

Diff: https://git.reviewboard.kde.org/r/118547/diff/


Testing
-------

Made the two changes needed in plasma-workspace. Everything seemed to be ok.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140605/800acf65/attachment.html>