Review Request 118547: Expose Formats as singleton
David Edmundson
david at davidedmundson.co.uk
Thu Jun 5 00:03:27 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118547/
-----------------------------------------------------------
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
Description
-------
Expose Formats as singleton
Formats is basically just a collection of invokable static methods.
This saves creating a few objects and makes for a a nicer API.
Without it you have to have a bit of code like:
- KCoreAddons.Formats {
- id: formats
- }
then do text:formats.formatData(...) in your labels
this becomes now
KCoreAddons.Format.formatData(...)
Diffs
-----
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 65dd75f
Diff: https://git.reviewboard.kde.org/r/118547/diff/
Testing
-------
Made the two changes needed in plasma-workspace. Everything seemed to be ok.
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140605/6d9fb168/attachment.html>
More information about the Kde-frameworks-devel
mailing list