Review Request 118538: Add a property containing the real edge a dialog is shown on

[David Edmundson]

> On June 4, 2014, 7:30 p.m., Marco Martin wrote:
> > what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please)
> > doing the animation on the proper direction can be tracked completely internally
> > 
> > also, plasmoids should never ever do a screen edge animation when in the middle of the desktop, the animation looks bad where it's clipped if it's not against a panel or a screen edge
> 
> David Edmundson wrote:
>     Milou places the most relevant item closest to the launcher.
>     
>
> 
> Marco Martin wrote:
>     Hmm, it would be relevant only in the case milou is iconified and in the desktop, that seems quite a narrow case.
>     api wise it may make sense a Plasma::Types::Direction visualParentDirection, *but* it would have to be exported in plasmoid as well, and I don't want anything like that here.
>     API that is added ad hoc for a single, extremely narrow use case is never a good idea.

kickoff changes direction too so the toolbar is closest to the launcher.

However, I'm not too fussed about the new property, I can remove the Q_PROPERTY and add it if we decide it's needed. The important part for me is making it show the correct borders and animate in the right direction.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118538/#review59234
-----------------------------------------------------------


On June 4, 2014, 7:07 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118538/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 7:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add a property containing the real edge a dialog is shown on.
> 
> If a dialog is meant to be shown on the left of an item, if there is not
> enough space it will be shown on the right.
> 
> We need to keep track of where we're actually shown in order to show the
> correct borders and perform the animation in the correct direction.
> 
> It is exposed as a property in case the dialog itself needs to know
> which side of the parent item it is, for example if needs to show an
> arrow to the parent.
> 
> --
> 
> Fixed some serious copy + paste fails in the hitting the bottom edge of
> the screen check.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.h 4009222 
>   src/plasmaquick/dialog.cpp 2f8227c 
> 
> Diff: https://git.reviewboard.kde.org/r/118538/diff/
> 
> 
> Testing
> -------
> 
> Ran dialog_positioning.qml in all 8 combinations of edges + preferred locations.
> (i.e placed near left edge, showed item with location set to both left and right)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140604/6ca8f4e5/attachment.html>