Review Request 118514: Add KColumnResizer to KWidgetsAddons

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/#review59170
-----------------------------------------------------------


What about adding something like this to Qt ?


src/kcolumnresizer.h
<https://git.reviewboard.kde.org/r/118514/#comment41197>

    Reading your blog http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/
    I have the impression that the documentation added here is less helpful than your blog.
    
    That said, can you add one of the example images? Have a look at kmessagewidget.h how to do this.



src/kcolumnresizer.h
<https://git.reviewboard.kde.org/r/118514/#comment41195>

    Doxygen comments without colon:
    @param layout The layout containing the widgets to add 
    
    Maybe add, tat the layout must be a QGridLayout or a QFormLayout.



src/kcolumnresizer.cpp
<https://git.reviewboard.kde.org/r/118514/#comment41193>

    The API should probably still be more safe in release mode. What happens if column == -1?



src/kcolumnresizer.cpp
<https://git.reviewboard.kde.org/r/118514/#comment41192>

    You can use auto here, if wanted (you can use auto much more often in your patch, btw.):
    
    if (auto gridLayout = qobject_cast<QGridLayout*>(layout)) {
        d->addWidgetsFromGridLayout(gridLayout, column);
        return;
    }
    
    if (auto formLayout = qobject_cast<QGridLayout*>(layout)) {
        // ...
    }


- Dominik Haumann


On June 4, 2014, 9:52 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118514/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 9:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer is a helper class I created long ago to help maintain uniform widths across layouts. You can learn more about it from the blog post I wrote back then: http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified the API a bit, added some documentation, and here it is.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 27b9084 
>   src/kcolumnresizer.h PRE-CREATION 
>   src/kcolumnresizer.cpp PRE-CREATION 
>   tests/CMakeLists.txt eccf887 
>   tests/kcolumnresizertest.h PRE-CREATION 
>   tests/kcolumnresizertest.cpp PRE-CREATION 
>   tests/kcolumnresizertest.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118514/diff/
> 
> 
> Testing
> -------
> 
> Manual test program behaves as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140604/2d38bacf/attachment-0001.html>