Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

[Alex Merry]

> On June 3, 2014, 10:16 a.m., Alex Merry wrote:
> > src/mdnsd-servicetypebrowser.cpp, line 51
> > <https://git.reviewboard.kde.org/r/118490/diff/1/?file=277690#file277690line51>
> >
> >     Interesting... any idea which monday?
> 
> Matthew Dawson wrote:
>     I'm assuming that is any Monday, as that used to be the day to break SIC/BIC on kdelibs.  It was there when I inherited the code.  I'll just remove the comment in an updated patch.

Ah, yes, I recall now.


> On June 3, 2014, 10:16 a.m., Alex Merry wrote:
> > src/servicetypebrowser.h, line 93
> > <https://git.reviewboard.kde.org/r/118490/diff/1/?file=277691#file277691line93>
> >
> >     Since when?
> 
> Matthew Dawson wrote:
>     At least since KDELibs 4 time.  Interestingly, Git shows the @deprecated came in 2008, from a commit you made :).  Looking back further, it seems to just have been considered unnecessary and should be removed as of 2007, and for the 4.4 releases effectively.  I'll update the comment if the function is kept.

Heh, so the sparse message is my fault :-)


> On June 3, 2014, 10:16 a.m., Alex Merry wrote:
> > src/servicetypebrowser.h, lines 97-99
> > <https://git.reviewboard.kde.org/r/118490/diff/1/?file=277691#file277691line97>
> >
> >     It looks like the mdnsd backend even just returns false, so this is not even reliable. With that in mind, I'd be tempted to make it an inline method that just always returns false.
> 
> Matthew Dawson wrote:
>     Is it still late to do a minor SIC change?  It appears the function is useless, and is uneeded.  Its only use seems to be for a structure similar to:
>     if (!isRunning()) {
>       startBrowse();
>     }
>     which can just be reduced to:
>     startBrowse();
>     as startBrowse can be called multiple times.
>     
>     If it is preferred to keep it for SC purposes, then I'll take your suggestion and just make it inline and return false.

I'd say at this point (after the last beta), and given the negligible cost of keeping it, it should stay.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118490/#review59066
-----------------------------------------------------------


On June 3, 2014, 6:59 a.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118490/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 6:59 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdnssd
> 
> 
> Description
> -------
> 
> Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.
> 
> Inline with the new defines used by Frameworks, remove the usage of the
> KDE_NO_DEPRECATED define.
> 
> 
> Diffs
> -----
> 
>   src/avahi-servicetypebrowser.cpp b3c14f84367d5093a6cee5ef3f684edc201a3f96 
>   src/dummy-servicetypebrowser.cpp 39a4b6b660bb47b68b5721535994487dbe2abbf6 
>   src/mdnsd-servicetypebrowser.cpp d16dd1fa1c692cd20e21f1a7d5471ac7956469b3 
>   src/servicetypebrowser.h 3cd10e36bf089e088e8a48bb0cf73daa4fb859c5 
> 
> Diff: https://git.reviewboard.kde.org/r/118490/diff/
> 
> 
> Testing
> -------
> 
> Code still compiles.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140604/29b472e2/attachment-0001.html>