Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic
David Faure
faure at kde.org
Wed Jun 4 07:50:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118486/#review59127
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On June 2, 2014, 10:03 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118486/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 10:03 p.m.)
>
>
> Review request for KDE Frameworks and Chusslove Illich.
>
>
> Repository: ki18n
>
>
> Description
> -------
>
> Put transcript plugin in kf5 subdir and simplify search logic
>
> Putting the plugin in a versioned subdirectory ensures there will not be
> any coinstallability issues with KF6 if it is Qt5-based. Using
> QPluginLoader to find the plugin makes for simpler, more reliable code.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 3099d2d29e43e40ac761694019f06aec41e54147
> src/klocalizedstring.cpp 4a4f6f8c1a79d4b101ae3df5e589cb629f4bd596
>
> Diff: https://git.reviewboard.kde.org/r/118486/diff/
>
>
> Testing
> -------
>
> Tests pass, but not sure how to test the installed location. Chusslove: do you have a standard way to test the loading and operation of the transcript plugin?
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140604/436bb417/attachment.html>
More information about the Kde-frameworks-devel
mailing list