Review Request 118473: reset m_request.cacheTag dates in sendQuery()
Marco Martin
notmart at gmail.com
Mon Jun 2 16:07:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118473/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kio
Description
-------
In relation to https://bugs.kde.org/show_bug.cgi?id=334767
seems that kio::file_copy calls fail because a wrong If-Modified-Since: is sent in the request header and the answer is almost always 304 not modified.
I compared the http kioslave with the kde4 version, and i seen that it used to reset m_request.cacheTag.servedDate
m_request.cacheTag.lastModifiedDate and m_request.cacheTag.expireDate in HTTPProtocol::sendQuery()
This has been removed in the Kf5 port, but if i restore it, KIO::file_copy seems to work correctly again
Diffs
-----
src/ioslaves/http/http.cpp c81ad41
Diff: https://git.reviewboard.kde.org/r/118473/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140602/bf14f46f/attachment.html>
More information about the Kde-frameworks-devel
mailing list