Review Request 118128: Use actual bytes formatter for sizes in KDirModel
Commit Hook
null at kde.org
Mon Jun 2 11:44:59 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118128/#review58955
-----------------------------------------------------------
This review has been submitted with commit 60171e82ae3f63c7af2e222f83924b26e8a3a42a by Martin Klapetek to branch master.
- Commit Hook
On May 29, 2014, 5 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118128/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 5 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Now I'm not sure if returning the unit together with the size won't break some things, but as it returns string already, I thought returning it in the "human readable" form would be better than always returning bytes.
>
>
> Diffs
> -----
>
> src/widgets/kdirmodel.cpp 70d5ee4
>
> Diff: https://git.reviewboard.kde.org/r/118128/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140602/410f60d5/attachment.html>
More information about the Kde-frameworks-devel
mailing list