Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

[Alex Merry]

> On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote:
> > src/platformtheme/CMakeLists.txt, line 4
> > <https://git.reviewboard.kde.org/r/118234/diff/1/?file=273903#file273903line4>
> >
> >     This workaround is quite important for 5.3.0 and older at least, maybe in those cases we should make it mandatory?
> 
> Martin Gräßlin wrote:
>     I have a feeling that the MacOS and Windows maintainer won't like a required XCB dependency :-)
> 
> Alex Merry wrote:
>     How about making it recommended? At least on non-Apple Unix systems.
> 
> Aleix Pol Gonzalez wrote:
>     MacOS or Windows shouldn't be running KDE's QPlatformTheme. Actually, we should probably call it Plasma QPlatformTheme.
> 
> Alex Merry wrote:
>     Which raises the question: does this belong in workspace?
> 
> Martin Gräßlin wrote:
>     could we move that discussion somewhere else? Right now we need to implement it in a way that it doesn't break the build of MacOS and Windows and this fix is super important to run the workspace at all, I really want to get it in fast. It's bad enough that it missed the beta release again.

Sure. Sorry for derailing.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118234/#review58445
-----------------------------------------------------------


On May 30, 2014, 6:15 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118234/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 6:15 a.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Bugs: 334858
>     https://bugs.kde.org/show_bug.cgi?id=334858
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Ensure the xcb connection gets flushed before the event dispatcher blocks
> 
> This is a workaround for Qt versions which do not yet have the change
> https://codereview.qt-project.org/85654
> 
> It is important to have this workaround as applications can get stalled
> when a framework uses xcb and doesn't flush the connection manually.
> 
> BUG: 334858
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/main.cpp 21d9aa0864e1887f5efbe4a05d264968af6e7e73 
>   src/platformtheme/config-platformtheme.h.cmake PRE-CREATION 
>   src/platformtheme/CMakeLists.txt da77cf816fe5f63e8eb9277d5d81d957b89c7966 
> 
> Diff: https://git.reviewboard.kde.org/r/118234/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140602/36ca6b40/attachment-0001.html>