Review Request 118449: Also set organization domain from KAboutData

David Edmundson david at davidedmundson.co.uk
Sun Jun 1 12:24:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118449/#review58885
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On June 1, 2014, 12:14 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118449/
> -----------------------------------------------------------
> 
> (Updated June 1, 2014, 12:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Also set organization domain from KAboutData
> 
> The doc says that it initializes the relevant properties of
> QCoreApplication. Having the organization domain not set is rather
> unexpected for a user.
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.cpp 8a51ec114101092612995058d8a91c1075881ccf 
> 
> Diff: https://git.reviewboard.kde.org/r/118449/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140601/0e15e668/attachment.html>


More information about the Kde-frameworks-devel mailing list