Review Request 119510: Fix untranslated menu entries

[Lukáš Tinkl]

> On Čec. 28, 2014, 8:12 odp., David Faure wrote:
> > I don't know about the bcp47 thing, but setting the locale to C is definitely definitely wrong.
> > 
> > This line of code in kdelibs4 was saying
> > 
> >    // force generating of KLocale object. if not, the database will get
> >    // be translated
> >    KGlobal::locale();
> > 
> > +2 to removing that completely.
> 
> Lukáš Tinkl wrote:
>     Here it returns just the language ("cs"), although the docu says: "Returns the dash-separated language, script and country (and possibly other BCP47 fields) of this locale as a string."
>     
>     Anyway I don't think it matters much as long as the same entry gets written into the database (lines 488 and 700)

Ship it?


- Lukáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119510/#review63359
-----------------------------------------------------------


On Čec. 28, 2014, 4:28 odp., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119510/
> -----------------------------------------------------------
> 
> (Updated Čec. 28, 2014, 4:28 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> This patch fixes QLocale usage in kbuildsycoca by not setting the default C locale when creating the sycoca database (leftover from a KLocale port?). Otherwise this results in menu entries being in English only (in effect KDesktopFile, KService and other classes returning the original strings instead of the uset-visible translated messages)
> 
> 
> Diffs
> -----
> 
>   src/kbuildsycoca/kbuildsycoca.cpp 2f8405c 
>   src/services/kservice.cpp c2b5ccf 
> 
> Diff: https://git.reviewboard.kde.org/r/119510/diff/
> 
> 
> Testing
> -------
> 
> Current Plasma 5 workspace/desktop
> 
> 
> File Attachments
> ----------------
> 
> translated systemsettings
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140731/1a6fd031/attachment.html>