Review Request 119542: create qapplication before using dbus

Luca Beltrame lbeltrame at kde.org
Wed Jul 30 05:41:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119542/#review63482
-----------------------------------------------------------


+1, from what I've seen it looks fairly harmless.

- Luca Beltrame


On Lug. 30, 2014, 12:43 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119542/
> -----------------------------------------------------------
> 
> (Updated Lug. 30, 2014, 12:43 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> qt doesn't take very kindly to using dbus before having a qcoreapplication,
> so move the app init before the helper proxy init (which might be using
> dbus) to avoid possible issues in the future
> 
> 
> Diffs
> -----
> 
>   src/kauthhelpersupport.cpp 99868803fdfaf99283d65a8ab61e7a32fb22e708 
> 
> Diff: https://git.reviewboard.kde.org/r/119542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140730/28e6a64a/attachment.html>


More information about the Kde-frameworks-devel mailing list