Review Request 119535: Move QML bindings for KUser to kdeclarative

[Marco Martin]

> On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote:
> > Can we consider including this in KCoreAddons?
> > 
> > I know KCoreAddons should only depend on QtCore, but then we can make it an optional dependency. If Qt5::Qml is there, then build the Qml plugin too.
> 
> Marco Martin wrote:
>     KCoreAddons can depend from anything in KCore
>     the Qt only one is KQuickControlAddons
> 
> David Edmundson wrote:
>     I'm confused.
>     
>     There is a framework called kcoreaddons
>     The kdeclarative framework has a plugin also called kcoreaddons.
>     
>     Which one are you both talking about?

err, kcoreaddons, right
kcoreaddons plugin, depending from KCoreAddons framework
(other framework maitainers didn't want the plugins to be in the framework itself to not make everything depend from qml)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/#review63441
-----------------------------------------------------------


On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119535/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 2:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Move QML bindings for KUser to kdeclarative
> 
> This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit.
> 
> The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c 
>   src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e 
>   src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION 
>   src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119535/diff/
> 
> 
> Testing
> -------
> 
> Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140729/86937f1c/attachment.html>