Review Request 119523: port TextField to QtControls

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119523/#review63363
-----------------------------------------------------------


Even if we fix the methods it's too close to 5.1 to merge right now. Definitely wait till after that so we have some time to find problems.


src/declarativeimports/plasmacomponents/qml/TextField.qml
<https://git.reviewboard.kde.org/r/119523/#comment44165>

    This is going to overlap with the text I think.
    It might be worth trying to upstream the concept of a clear button rather than working round it here. It'll be less work in the long term. 
    
    I filed a bug report on this once, they're ok with the concept but want to make it so you can add any random button on the left/right, not just clear.



src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml
<https://git.reviewboard.kde.org/r/119523/#comment44164>

    RAndon capitals


Which methods do we need the inner control for? I saw positionAtPos and positionToRectangle, any others?

- David Edmundson


On July 28, 2014, 6:10 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119523/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 6:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports TextField to Qt Controls.
> 
> Not sure if is really meargeable tough, because the old one used to export several properties and functions more, but they are not possible anymore, because in order for them to work is needed the access to the internal TextInput, and we don't have that, so some api should have to be dropped, breaking the compatibility promise.
> (another option would be to still use an own implementation, but use a compatible style anyways)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58 
>   src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140728/51af05ac/attachment.html>