Review Request 119510: Fix untranslated menu entries
Lukáš Tinkl
lukas at kde.org
Mon Jul 28 18:01:36 UTC 2014
> On Čec. 28, 2014, 7:56 odp., Aleix Pol Gonzalez wrote:
> > src/services/kservice.cpp, line 57
> > <https://git.reviewboard.kde.org/r/119510/diff/1/?file=293809#file293809line57>
> >
> > Unrelated change, commit separately.
Ok, I'll make sure to split the commit into 2
On Čec. 28, 2014, 7:56 odp., Lukáš Tinkl wrote:
> > +1, makes sense to me. I'd like a from one of our l10n gurus too. ;)
Fine, here's a +1 from me ;p
- Lukáš
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119510/#review63356
-----------------------------------------------------------
On Čec. 28, 2014, 4:28 odp., Lukáš Tinkl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119510/
> -----------------------------------------------------------
>
> (Updated Čec. 28, 2014, 4:28 odp.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> This patch fixes QLocale usage in kbuildsycoca by not setting the default C locale when creating the sycoca database (leftover from a KLocale port?). Otherwise this results in menu entries being in English only (in effect KDesktopFile, KService and other classes returning the original strings instead of the uset-visible translated messages)
>
>
> Diffs
> -----
>
> src/kbuildsycoca/kbuildsycoca.cpp 2f8405c
> src/services/kservice.cpp c2b5ccf
>
> Diff: https://git.reviewboard.kde.org/r/119510/diff/
>
>
> Testing
> -------
>
> Current Plasma 5 workspace/desktop
>
>
> File Attachments
> ----------------
>
> translated systemsettings
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png
>
>
> Thanks,
>
> Lukáš Tinkl
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140728/c2f27e16/attachment.html>
More information about the Kde-frameworks-devel
mailing list