Review Request 119464: port ToolButton to QtControls

[Marco Martin]

> On July 25, 2014, 3:57 p.m., Andrew Lake wrote:
> > src/declarativeimports/plasmacomponents/qml/ToolButton.qml, line 30
> > <https://git.reviewboard.kde.org/r/119464/diff/1/?file=292702#file292702line30>
> >
> >     Just curious, any reason to not use ToolButton here?
> >     
> >     http://qt-project.org/doc/qt-5/qml-qtquick-controls-toolbutton.html

I'm inheriting button so reuses some of he custom stuff, since i seen that toolbutton in qtcontrols just inherits hit button..
anyways would be easy enough to inherit instead the qtcontrols toolbutton and duplicate the custom stuff needed for compatibility instead


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/#review63169
-----------------------------------------------------------


On July 25, 2014, 1:47 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119464/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 1:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports ToolButton.
> It's a different style than Button since it's way more complicated.
> 
> The ugly thing here is that QtControls ToolButton doesn't have a flat property, it should probably be upstreamed, at least for compatibility with the qwidgets ToolButton
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
>   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 
>   src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 20caef6 
>   src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119464/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140725/a5c91842/attachment-0001.html>