Review Request 119417: kconfig: Fix QBasicAtomicInt being treated as int (reposted)

Alex Merry alex.merry at kde.org
Fri Jul 25 12:43:41 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119417/#review63142
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On July 22, 2014, 11:35 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119417/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 11:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> kconfig fails building because QBasicAtomicInt is being treated as an int. This patch fixes that problem. It was posted for review by Andreas Xavier (https://git.reviewboard.kde.org/r/119257/), but he later discarded it. I have asked him many times why it was discarded, with no answer whatsoever.
> 
> Since this patch is needed to compile kconfig, I resend it.
> 
> 
> Diffs
> -----
> 
>   src/core/kconfig.cpp 14a5d39 
> 
> Diff: https://git.reviewboard.kde.org/r/119417/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140725/c6a69d24/attachment.html>


More information about the Kde-frameworks-devel mailing list