Review Request 119457: Script to Fix ecm_install_icons Deprecation Warnings

David Narváez david.narvaez at computer.org
Fri Jul 25 08:37:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119457/
-----------------------------------------------------------

(Updated July 25, 2014, 8:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kde-dev-scripts


Description
-------

The script
1) Fixes icon categories when found wrong, eg. action -> actions
2) Renames icons to remove theme prefix
3) Rewrites the CMakeLists.txt file to install icons grouped by themes

It does not support l10n codes.


Diffs
-----

  kf5/fix-ecm-install-icons.pl PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119457/diff/


Testing
-------

1) Unpack the attached test repository
2) Configure the repository using cmake - should display warnings
3) Fix the CMakeLists.txt file using this script
4) Reconfigure the repository using cmake - warnings should be gone


File Attachments
----------------

Test Repository
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/25/f598db77-95a6-4505-b02d-72304b79d65b__iconstest.tgz


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140725/46d3c32e/attachment.html>


More information about the Kde-frameworks-devel mailing list