Review Request 119455: make Button a QtControl

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63110
-----------------------------------------------------------


I think this is nearly good to go. A few questions below.


src/declarativeimports/core/iconitem.cpp
<https://git.reviewboard.kde.org/r/119455/#comment43857>

    Do we want to clear the current icon when this happens?
    
    If so we have to start the loadPixmap timer at the bottom of the function I think.



src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml
<https://git.reviewboard.kde.org/r/119455/#comment43858>

    I was thinking this can become just
    
    property real minimumWidth: Layout.minimumWidth
    
    Also this is currently wrong; we're adding style.padding.left as the gap between icon + label, but the RowLayout spacing is units.smallSpacing, so they are different



src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml
<https://git.reviewboard.kde.org/r/119455/#comment43860>

    I'd use 
    
    Layout.alignment: Qt::AlignVCenter
    so we don't mix and match anchors & layouts in a bit of code.
    
    up to you.


- David Edmundson


On July 24, 2014, 6:17 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119455/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 6:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this makes Button inherit from the QtControl and annd an accompaining plasma-looking theme
> 
> now, the ugly part of the patch:
> iconSource is an url, so it screws up passing freedesktop compatible names (it expects names of pngs local to the qml file directory, testimony of the main platform target for controls actually being android/ios). one solution may be overriding iconSource as a normal string, but i would like the theme working also on a plain Button, so it extract only the filename from the url.
> 
> 
> Diffs
> -----
> 
>   examples/applets/widgetgallery/contents/ui/Buttons.qml 9134df9 
>   src/declarativeimports/core/iconitem.cpp 38012cc 
>   src/declarativeimports/plasmacomponents/qml/Button.qml 262e20f 
>   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119455/diff/
> 
> 
> Testing
> -------
> 
> in both a normal plasma session or the widget gallery buttons work fine, painting is 100% identical
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140725/b986d4f4/attachment-0001.html>