Review Request 119455: make Button a QtControl

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
-----------------------------------------------------------

(Updated July 24, 2014, 4:31 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

better rendering for the menu arrow, support checked buttons


Repository: plasma-framework


Description
-------

this makes Button inherit from the QtControl and annd an accompaining plasma-looking theme

now, the ugly part of the patch:
iconSource is an url, so it screws up passing freedesktop compatible names (it expects names of pngs local to the qml file directory, testimony of the main platform target for controls actually being android/ios). one solution may be overriding iconSource as a normal string, but i would like the theme working also on a plain Button, so it extract only the filename from the url.


Diffs (updated)
-----

  examples/applets/widgetgallery/contents/ui/Buttons.qml 9134df9 
  src/declarativeimports/core/iconitem.cpp 38012cc 
  src/declarativeimports/plasmacomponents/qml/Button.qml 262e20f 
  src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119455/diff/


Testing
-------

in both a normal plasma session or the widget gallery buttons work fine, painting is 100% identical


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140724/1ff0cb8d/attachment.html>