Review Request 119435: Replacing also kaction.h header include

Laurent Montel montel at kde.org
Thu Jul 24 06:06:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119435/#review63029
-----------------------------------------------------------

Ship it!


Ship It!

- Laurent Montel


On juil. 23, 2014, 9:26 après-midi, David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119435/
> -----------------------------------------------------------
> 
> (Updated juil. 23, 2014, 9:26 après-midi)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde-dev-scripts
> 
> 
> Description
> -------
> 
> Replacing also kaction.h header include
> 
> 
> Diffs
> -----
> 
>   kf5/convert-kaction.pl 0fa3f10cddd7f690edf5454a81bc5113d67abdcb 
> 
> Diff: https://git.reviewboard.kde.org/r/119435/diff/
> 
> 
> Testing
> -------
> 
> Sample commit using this script:
> 
> diff --git a/filters/exporter.h b/filters/exporter.h
> index d5f14f1..8ef83d1 100644
> --- a/filters/exporter.h
> +++ b/filters/exporter.h
> @@ -18,7 +18,7 @@
>  #ifndef KIG_FILTERS_EXPORTER_H
>  #define KIG_FILTERS_EXPORTER_H
>  
> -#include <kaction.h>
> +#include <QAction>
>  
>  #include <vector>
>  
> @@ -41,7 +41,7 @@ public:
>  };
>  
>  class ExporterAction
> -  : public KAction
> +  : public QAction
>  {
>    Q_OBJECT
>  
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140724/f73fb5a9/attachment.html>


More information about the Kde-frameworks-devel mailing list