KF5 Porting: Installing Icons

[David Narvaez]

Hi,

The information at [0] seems to indicate I just need to worry about
renaming files to match the new categories (btw, is there a script for
that?) but what I get from

CMake Warning (dev) at
/usr/share/ECM/modules/ECMInstallIcons.cmake:205 (message):
  ecm_install_icons() with no ICONS argument is deprecated
Call Stack (most recent call first):
  icons/CMakeLists.txt:2 (ecm_install_icons)
This warning is for project developers.  Use -Wno-dev to suppress it.

is that I need to update to

#   ecm_install_icons(ICONS <icon> [<icon> [...]]
#                     DESTINATION <icon_install_dir>
#                     [LANG <l10n_code>]
#                     [THEME <theme>])

which seems to me like I need to explicitly list all icons in the dir, and

# The given icons, whose names must match the pattern::
#
#   <size>-<group>-<name>.<ext>

seems to indicate I need to rename all of the files to remove the
theme from the prefix.

Am I correct? Should I update the wiki with the complete oddyssey to a
correct ecm_install_icions?

David E. Narvaez

[0] https://community.kde.org/Frameworks/Porting_Notes#Installing_Icons