Review Request 119406: Always take the painter based path for composeOverBorder

David Edmundson david at davidedmundson.co.uk
Wed Jul 23 13:53:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119406/
-----------------------------------------------------------

(Updated July 23, 2014, 1:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

Always take the painter based path for composeOverBorder

We previously only supported compose-over-border when the centre was not
set to tile.

A recent change to the breeze theme put everything into tiling, even if
some things used compose-over-border, which broke opaque widgets.

Given that creating an opacityMask loads most of the image anyway, we
can make use of the FrameSVG painter path and avoid any additional code
complexity here.


Diffs
-----

  src/declarativeimports/core/framesvgitem.cpp a5fe315 

Diff: https://git.reviewboard.kde.org/r/119406/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140723/5764ff2f/attachment.html>


More information about the Kde-frameworks-devel mailing list