Review Request 119410: Document KDED dependency.

Albert Astals Cid aacid at kde.org
Tue Jul 22 17:22:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119410/#review62902
-----------------------------------------------------------


Have to run now but want to comment so i don't forget.

Have you checked this calls are a hard dependency? Last i remember the thing still works without them.

- Albert Astals Cid


On jul. 22, 2014, 3:47 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119410/
> -----------------------------------------------------------
> 
> (Updated jul. 22, 2014, 3:47 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> It looks like org.kde.kded5 is called via dbus in a few places, for example in src/widgets/jobuidelegate.cpp.
> 
> If this is the case, it should be documented so we know to ensure it's available.
> 
> 
> Diffs
> -----
> 
>   metainfo.yaml 102380eca8c77a34f4ab5c687a51952168b34225 
> 
> Diff: https://git.reviewboard.kde.org/r/119410/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140722/ec8e463e/attachment.html>


More information about the Kde-frameworks-devel mailing list