Review Request 119409: framework part of the applet alternatives shooser

Marco Martin notmart at gmail.com
Tue Jul 22 16:10:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119409/
-----------------------------------------------------------

(Updated July 22, 2014, 4:10 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

this is the little part in plasma-framework for the applet alternatives chooser.
works together the branch mart/alternativesConfig of plasma-workspace and plsma-desktop.
for how it looks and why, see the vdg forum thread:
https://forum.kde.org/viewtopic.php?f=285&t=122067&p=315919#p315919

still possible problems:
* the branch in framework is kinda screwed, too many merges, is probably better to push this diff as a single commit
* I'm not sure about using a new desktop file entry X-Plasma-Provides, *maybe* Categories could be enough, but it may produce many false positives as well


Diffs (updated)
-----

  src/plasma/data/servicetypes/plasma-applet.desktop b75c3d6 
  src/scriptengines/qml/plasmoid/appletinterface.h fe50825 
  src/scriptengines/qml/plasmoid/appletinterface.cpp e5f7985 

Diff: https://git.reviewboard.kde.org/r/119409/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140722/92e4a095/attachment.html>


More information about the Kde-frameworks-devel mailing list