Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

Alexander Richardson arichardson.kde at gmail.com
Tue Jul 22 11:17:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
-----------------------------------------------------------

(Updated Juli 22, 2014, 1:17 nachm.)


Review request for KDE Frameworks.


Changes
-------

added unit test for forEachPlugin


Repository: kcoreaddons


Description (updated)
-------

- Add new class KPluginMetaData

This class simplifies reading the metadata from a qt plugin by providing
type-safe accessor functions for known keys. It is meant as a
replacment for KPluginInfo for applications that do not need all the
features provided by KService.

- Add functions for loading all plugins from a given directory

KPluginLoader::findPlugins() can generally be used as a replacement for
KServiceTypeTrader::self()->query("...").

- Adapt jsonplugin metadata to the format used by KPluginMetaData

- Add a unit test for KPluginLoader::instantiatePlugins()

- Add a unit test for KPluginMetaData

- Improve KPluginLoader unit test

This adds a test for KPluginLoader::forEachPlugin() and also adds a
test using a relative path for KPluginLoader::instantiatePlugins()


Diffs (updated)
-----

  autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd 
  autotests/jsonplugin.json d86fad49e5d074762d70282b3ace4bf3e6db58df 
  autotests/jsonplugin2.h PRE-CREATION 
  autotests/jsonplugin2.cpp PRE-CREATION 
  autotests/jsonplugin2.json PRE-CREATION 
  autotests/kpluginloadertest.cpp c8225c02de3a64cae29d88954700dbc6f03ff1b0 
  autotests/kpluginmetadatatest.cpp PRE-CREATION 
  src/lib/CMakeLists.txt 26eb5a1d4d56742a3395ba2645290bea15aee181 
  src/lib/plugin/kpluginloader.h 0b7a53d3b879cec1d755b849d9d8c640d251a379 
  src/lib/plugin/kpluginloader.cpp 9b3c5b6aec537b03b0d8341b33f6f4d7a76c8344 
  src/lib/plugin/kpluginmetadata.h PRE-CREATION 
  src/lib/plugin/kpluginmetadata.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119079/diff/


Testing
-------

Added a unit test

Should easily allow loading all plugins from a given directory without needing kbuildsycoca


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140722/8bafe8ef/attachment.html>


More information about the Kde-frameworks-devel mailing list