Review Request 119382: Port kio-mtp to KF5

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119382/#review62770
-----------------------------------------------------------



kio_mtp.cpp
<https://git.reviewboard.kde.org/r/119382/#comment43512>

    These can be const methods, or even static. *3



kio_mtp.cpp
<https://git.reviewboard.kde.org/r/119382/#comment43514>

    These are flags, you can do both in one.



kio_mtp.cpp
<https://git.reviewboard.kde.org/r/119382/#comment43513>

    why would there be a trailing slash on a filename? I'm quite confused as to the stripping slashes all over here.


- David Edmundson


On July 21, 2014, 11:02 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119382/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 11:02 a.m.)
> 
> 
> Review request for KDE Frameworks and Philipp Schmidt.
> 
> 
> Repository: kio-mtp
> 
> 
> Description
> -------
> 
> I ported kio-mtp to KF5 including:
> kDebug -> qCDebug
> KUrl -> QUrl
> 
> And it doesn't need Kdelibs4Support.
> 
> Also one thing which should be probably considered is including kio-mtp in kio-extras.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb27440 
>   devicecache.h 1fa3932 
>   devicecache.cpp 54ca56f 
>   filecache.h 590e799 
>   filecache.cpp dfd4fe6 
>   kio_mtp.h b05f09b 
>   kio_mtp.cpp 6e587fa 
>   kio_mtp_helpers.h b66adbd 
>   kio_mtp_helpers.cpp 0f9ddbc 
> 
> Diff: https://git.reviewboard.kde.org/r/119382/diff/
> 
> 
> Testing
> -------
> 
> My phone is visible in Dolphin and I was able to finally copy my photos from phone to my laptop.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140721/e5c71260/attachment-0001.html>