Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice
Alexander Richardson
arichardson.kde at gmail.com
Fri Jul 18 13:31:46 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119356/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
-------
Unlike the original KConfig based tool it now includes all translations
for keys and not just the one for the current locale. Also added a unit
test for it.
Add a verbose option to desktoptojson
Also check for missing entries in the desktoptojson unit test
make the desktoptojson unit test less verbose
install a KF5CoreAddonsMacros.cmake with kcoreaddons_desktop_to_json()
Convert the .desktop files to a new .json format and adapt tests
This format is used by KPluginMetaData and allows removing all the
useless X-KDE-PluginInfo prefixes
Diffs
-----
src/desktoptojson/main.cpp PRE-CREATION
CMakeLists.txt d45309f7f5e84c59b2f4d0bf3de68b330d782102
KF5CoreAddonsConfig.cmake.in c471006ee2c8f52b5c22c5edc617554f671237d1
autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd
KF5CoreAddonsMacros.cmake PRE-CREATION
src/desktoptojson/desktoptojson.cpp PRE-CREATION
src/desktoptojson/desktoptojson.h PRE-CREATION
src/desktoptojson/CMakeLists.txt PRE-CREATION
src/CMakeLists.txt ef1eea63c92532eea7003c67b59bb3649bc02484
autotests/desktoptojsontest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119356/diff/
Testing
-------
Unit test works and passes.
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140718/98bcb5ce/attachment.html>
More information about the Kde-frameworks-devel
mailing list