Review Request 119349: typo in signal names ( upowermanager )
Lukáš Tinkl
lukas at kde.org
Fri Jul 18 09:50:38 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119349/#review62638
-----------------------------------------------------------
Hmm, my upower (and also the newer one) has DeviceAdded/Removed signals... how did you come to this conclusion? Have you done any testing?
- Lukáš Tinkl
On Čec. 18, 2014, 7:31 dop., Ömer Fadıl Usta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119349/
> -----------------------------------------------------------
>
> (Updated Čec. 18, 2014, 7:31 dop.)
>
>
> Review request for KDE Frameworks and Solid.
>
>
> Repository: solid
>
>
> Description
> -------
>
> There were some typos for signals in upowermanager such as ;
> DeviceAdded -- > deviceAdded
> DeviceRemoved -- > deviceRemoved
>
>
> Diffs
> -----
>
> src/solid/devices/backends/upower/upowermanager.cpp 53c8580
>
> Diff: https://git.reviewboard.kde.org/r/119349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ömer Fadıl Usta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140718/a3581e60/attachment.html>
More information about the Kde-frameworks-devel
mailing list