Review Request 119329: return invalid for packages with Hidden=true in the metadata

Rohan Garg rohangarg at kubuntu.org
Thu Jul 17 10:01:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119329/#review62561
-----------------------------------------------------------

Ship it!


The reasoning is that it makes it easier for downstream to just override the desktop file as part of their customization package.

- Rohan Garg


On July 17, 2014, 3:20 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119329/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 3:20 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This originates from the request of downstreams to hide packages that are still installed.
> why should be easier than not installing them i don't know, *but* semantically I think it makes sense act as if the package was not existing when the metadata says it's hidden
> 
> 
> Diffs
> -----
> 
>   src/plasma/package.cpp 6ba7a6f 
> 
> Diff: https://git.reviewboard.kde.org/r/119329/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140717/76e729c2/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list