Review Request 119323: fix auth race condition

Hrvoje Senjan hrvoje.senjan at gmail.com
Wed Jul 16 16:18:21 UTC 2014



> On July 16, 2014, 6:06 p.m., Luca Beltrame wrote:
> > I ran the (few) autotests, and those also pass. I can't test it runtime, will do so later hopefully.

a few runtime checks (e.g. org.kde.powerdevil.backlighthelper) seem to work =)

also polkit reports system-bus-name is used


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119323/#review62520
-----------------------------------------------------------


On July 16, 2014, 6:05 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119323/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 6:05 p.m.)
> 
> 
> Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> pid based auth is racy because of pid reuse, don't use it.
> 
> 
> Diffs
> -----
> 
>   src/backends/polkit-1/Polkit1Backend.cpp 165f7bb 
> 
> Diff: https://git.reviewboard.kde.org/r/119323/diff/
> 
> 
> Testing
> -------
> 
> it builds
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140716/fc2b754b/attachment.html>


More information about the Kde-frameworks-devel mailing list